[wrangler] Remove ambient vitest types from generated tsconfig.jsons
#2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fd986a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4342514155/npm-package-wrangler-2839You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2839/npm-package-wrangler-2839Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4342514155/npm-package-wrangler-2839 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4342514155/npm-package-cloudflare-pages-shared-2839Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #2839 +/- ##
=======================================
Coverage 74.05% 74.05%
=======================================
Files 166 166
Lines 10218 10218
Branches 2734 2734
=======================================
Hits 7567 7567
Misses 2651 2651 |
JacobMGEvans
approved these changes
Mar 2, 2023
mrbbot
force-pushed
the
bcoll/remove-vitest-ambient
branch
from
9dc956f
to
dda8647
Compare
mrbbot
changed the title
vitest types from generated tsconfig.jsonsvitest types from generated tsconfig.jsons
Previously, `wrangler init` generated a `tsconfig.json` with `"types": [..., "vitest"]`, even if Vitest tests weren't generated. Unlike Jest, Vitest doesn't provide global APIs by default (https://vitest.dev/config/#globals), so there's no need for ambient types.
mrbbot
force-pushed
the
bcoll/remove-vitest-ambient
branch
from
dda8647
to
fd986a4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test:
Previously,
wrangler initgenerated atsconfig.jsonwith"types": [..., "vitest"], even if Vitest tests weren't generated. Unlike Jest, Vitest doesn't provide global APIs by default (https://vitest.dev/config/#globals), so there's no need for ambient types. Because these ambient types don't actually exist, this was causing issues during type checking.Associated docs issues/PR:
N/A
Author has included the following, where applicable:
Reviewer has performed the following, where applicable:
Fixes #2773.