-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include .wrangler directory in gitignore template #2845
Include .wrangler directory in gitignore template #2845
Conversation
🦋 Changeset detectedLatest commit: 0a05c7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks.
.changeset/gold-laws-sleep.md
Outdated
"wrangler": patch | ||
--- | ||
|
||
feature: include .wrangler directory in gitignore template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feature: include .wrangler directory in gitignore template | |
chore: include .wrangler directory in gitignore template |
I think we can avoid the feature marker here. It is more of an internal tweak.
I might go so far as to suggest it does not need a changeset....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a publicly observable behavior change? If so, why wouldn't we want a changeset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is only noticeable for people who are contributing to Wrangler. I.e. if they run a template from within the working directory of the workers-sdk repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a public change. This template is use when you choose git to manage a worker during init.
workers-sdk/packages/wrangler/src/init.ts
Line 237 in 2b64176
readFileSync(path.join(getBasePath(), "templates/gitignore")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh!! So sorry. I thought this change was in /templates/.gitignore
, not /packages/wrangler/templates/.gitignore.
.
Please ignore my comments!
Or actually, can you make it clear in the changeset that this affects the output of generating a new worker using wrangler init
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4325934403/npm-package-wrangler-2845 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2845/npm-package-wrangler-2845 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4325934403/npm-package-wrangler-2845 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4325934403/npm-package-cloudflare-pages-shared-2845 Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #2845 +/- ##
=======================================
Coverage 74.05% 74.05%
=======================================
Files 166 166
Lines 10218 10218
Branches 2734 2734
=======================================
Hits 7567 7567
Misses 2651 2651 |
What this PR solves / how to test:
Add the
.wrangler
directory to thegitignore
template.Author has included the following, where applicable:
TestsReviewer has performed the following, where applicable: