Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include .wrangler directory in gitignore template #2845

Merged

Conversation

Cyb3r-Jak3
Copy link
Contributor

What this PR solves / how to test:

Add the .wrangler directory to the gitignore template.

Author has included the following, where applicable:

  • Tests
  • Changeset

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@Cyb3r-Jak3 Cyb3r-Jak3 requested a review from a team as a code owner March 3, 2023 02:59
@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2023

🦋 Changeset detected

Latest commit: 0a05c7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks.

"wrangler": patch
---

feature: include .wrangler directory in gitignore template
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
feature: include .wrangler directory in gitignore template
chore: include .wrangler directory in gitignore template

I think we can avoid the feature marker here. It is more of an internal tweak.
I might go so far as to suggest it does not need a changeset....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a publicly observable behavior change? If so, why wouldn't we want a changeset?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is only noticeable for people who are contributing to Wrangler. I.e. if they run a template from within the working directory of the workers-sdk repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a public change. This template is use when you choose git to manage a worker during init.

readFileSync(path.join(getBasePath(), "templates/gitignore"))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh!! So sorry. I thought this change was in /templates/.gitignore, not /packages/wrangler/templates/.gitignore..

Please ignore my comments!

Or actually, can you make it clear in the changeset that this affects the output of generating a new worker using wrangler init?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4325934403/npm-package-wrangler-2845

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2845/npm-package-wrangler-2845

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4325934403/npm-package-wrangler-2845 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4325934403/npm-package-cloudflare-pages-shared-2845

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #2845 (0a05c7c) into main (2b64176) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2845   +/-   ##
=======================================
  Coverage   74.05%   74.05%           
=======================================
  Files         166      166           
  Lines       10218    10218           
  Branches     2734     2734           
=======================================
  Hits         7567     7567           
  Misses       2651     2651           

@petebacondarwin petebacondarwin merged commit e3c036d into cloudflare:main Mar 6, 2023
@github-actions github-actions bot mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants