Fix --experimental-local with wrangler pages dev
#2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b52c948 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4343105943/npm-package-wrangler-2855You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2855/npm-package-wrangler-2855Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4343105943/npm-package-wrangler-2855 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4343105943/npm-package-cloudflare-pages-shared-2855Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #2855 +/- ##
=======================================
Coverage 74.05% 74.05%
=======================================
Files 166 166
Lines 10218 10218
Branches 2734 2734
=======================================
Hits 7567 7567
Misses 2651 2651
|
mrbbot
approved these changes
Mar 6, 2023
GregBrimble
force-pushed
the
fix-experimental-local-pages-dev
branch
from
fbaa712
to
b52c948
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test:
wrangler pages dev --experimental-localwill no longer fail with an error likelocal worker: TypeError: generateASSETSBinding2 is not a function.Author has included the following, where applicable:
Reviewer has performed the following, where applicable:
Fixes # [insert issue number].