Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] Fix compile loop with _worker.js and wrangler pages dev #2873

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

GregBrimble
Copy link
Member

@GregBrimble GregBrimble commented Mar 8, 2023

What this PR solves / how to test:

  • Run npm run dev in fixtures/pages-workerjs-app
  • Note the lack of compile loop :)

Associated docs issues/PR:

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

  • Tests
  • Changeset

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Fixes # [insert issue number].

@GregBrimble GregBrimble requested review from a team as code owners March 8, 2023 11:56
@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023

🦋 Changeset detected

Latest commit: 493f381

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #2873 (493f381) into main (763f3f6) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2873      +/-   ##
==========================================
+ Coverage   73.93%   73.96%   +0.02%     
==========================================
  Files         166      166              
  Lines       10251    10251              
  Branches     2745     2745              
==========================================
+ Hits         7579     7582       +3     
+ Misses       2672     2669       -3     
Impacted Files Coverage Δ
packages/wrangler/src/pages/dev.ts 18.77% <0.00%> (ø)
packages/wrangler/src/git-client.ts 43.75% <0.00%> (+4.16%) ⬆️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts 100.00% <0.00%> (+5.26%) ⬆️

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 😃

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4364038159/npm-package-wrangler-2873

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2873/npm-package-wrangler-2873

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4364038159/npm-package-wrangler-2873 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4364038159/npm-package-cloudflare-pages-shared-2873

Note that these links will no longer work once the GitHub Actions artifact expires.

@petebacondarwin petebacondarwin merged commit 5bcc333 into main Mar 8, 2023
@petebacondarwin petebacondarwin deleted the fix-compile-loop branch March 8, 2023 12:55
@github-actions github-actions bot mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants