Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug logging for Pages upload #2884

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Fix debug logging for Pages upload #2884

merged 2 commits into from
Mar 9, 2023

Conversation

WalshyDev
Copy link
Member

What this PR solves / how to test:

Just replaces our console.debugs with logger.debug.

Associated docs issues/PR:
N/A

Author has included the following, where applicable:

  • Tests
  • Changeset

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Fixes # [insert issue number].

@WalshyDev WalshyDev requested review from a team as code owners March 9, 2023 13:19
@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2023

🦋 Changeset detected

Latest commit: 679bcea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4374861406/npm-package-wrangler-2884

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2884/npm-package-wrangler-2884

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4374861406/npm-package-wrangler-2884 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4374861406/npm-package-cloudflare-pages-shared-2884

Note that these links will no longer work once the GitHub Actions artifact expires.

@CarmenPopoviciu
Copy link
Contributor

LGTM. Pls make sure you squash those commits before you merge

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #2884 (679bcea) into main (ff35b9d) will increase coverage by 1.15%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2884      +/-   ##
==========================================
+ Coverage   72.80%   73.96%   +1.15%     
==========================================
  Files         162      166       +4     
  Lines        9961    10251     +290     
  Branches     2652     2745      +93     
==========================================
+ Hits         7252     7582     +330     
+ Misses       2709     2669      -40     
Impacted Files Coverage Δ
packages/wrangler/src/pages/upload.tsx 83.43% <60.00%> (ø)
packages/wrangler/src/dev/validate-dev-props.ts 88.23% <0.00%> (-11.77%) ⬇️
packages/wrangler/src/pages/build.ts 67.03% <0.00%> (-9.64%) ⬇️
packages/wrangler/src/pages/buildFunctions.ts 90.24% <0.00%> (-4.36%) ⬇️
packages/wrangler/src/deployments.ts 69.38% <0.00%> (-2.49%) ⬇️
packages/wrangler/src/create-worker-preview.ts 8.97% <0.00%> (-0.75%) ⬇️
...ckages/wrangler/src/pages/functions/buildPlugin.ts 19.35% <0.00%> (-0.65%) ⬇️
packages/wrangler/src/dev/local.tsx 21.77% <0.00%> (-0.54%) ⬇️
packages/wrangler/src/dev/start-server.ts 65.60% <0.00%> (-0.43%) ⬇️
packages/wrangler/src/pages/dev.ts 18.77% <0.00%> (-0.17%) ⬇️
... and 34 more

@WalshyDev WalshyDev merged commit e33bea9 into main Mar 9, 2023
@WalshyDev WalshyDev deleted the walshy/fix-debugs branch March 9, 2023 13:37
@github-actions github-actions bot mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants