-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow cloudflare-specific js module #2905
Conversation
🦋 Changeset detectedLatest commit: ec3c8ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4436097268/npm-package-wrangler-2905 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2905/npm-package-wrangler-2905 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4436097268/npm-package-wrangler-2905 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4436097268/npm-package-cloudflare-pages-shared-2905 Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #2905 +/- ##
==========================================
+ Coverage 73.94% 73.98% +0.03%
==========================================
Files 167 167
Lines 10295 10299 +4
Branches 2748 2748
==========================================
+ Hits 7613 7620 +7
+ Misses 2682 2679 -3
|
Thanks for getting the ball rolling on this. We will also need to add a changeset and a test or two. |
The test here would be if I could publish (or build) a script that tried to import this module. Is there an existing test suite that this could fit into? |
Added test and changeset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for the quick turnaround @edevil - just a suggestion for the changeset description. Otherwise LGTM.
Mark cloudflare-specific js module as external so that scripts can be published that reference it.
Mark cloudflare-specific js module as external so that scripts can be published that reference it.
What this PR solves / how to test:
import { EmailMessage } from "cloudflare:email";
Author has included the following, where applicable:
Reviewer has performed the following, where applicable:
[ ] Checked for creation of associated docs updates: no documentation needed for this just yet. I assume when the first officialcloudflare:..
prefixed modules are announced there will be docs associated with it.