-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable the use of send email bindings #2914
Conversation
🦋 Changeset detectedLatest commit: ccafeb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4471821425/npm-package-wrangler-2914 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2914/npm-package-wrangler-2914 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4471821425/npm-package-wrangler-2914 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4471821425/npm-package-cloudflare-pages-shared-2914 Note that these links will no longer work once the GitHub Actions artifact expires. |
Add support for adding send email bindings to worker scripts. These bindings can have 3 different types: - Unrestricted - Targeted - Allowlist
a91281e
to
ccafeb6
Compare
Codecov Report
@@ Coverage Diff @@
## main #2914 +/- ##
==========================================
- Coverage 74.05% 74.03% -0.03%
==========================================
Files 167 167
Lines 10419 10449 +30
Branches 2786 2798 +12
==========================================
+ Hits 7716 7736 +20
- Misses 2703 2713 +10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but I'd like at least one more fromDevProd to check it too.
Hey @mrbbot, mind adding a review? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too! ✅
Nice! Can we merge? |
Thanks! |
Add support for adding send email bindings to worker scripts. These bindings can have 3 different types:
Author has included the following, where applicable:
Reviewer has performed the following, where applicable: