Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable the use of send email bindings #2914

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

edevil
Copy link
Contributor

@edevil edevil commented Mar 17, 2023

Add support for adding send email bindings to worker scripts. These bindings can have 3 different types:

  • Unrestricted
  • Targeted
  • Allowlist

Author has included the following, where applicable:

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@edevil edevil requested a review from a team as a code owner March 17, 2023 16:45
@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2023

🦋 Changeset detected

Latest commit: ccafeb6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4471821425/npm-package-wrangler-2914

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2914/npm-package-wrangler-2914

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4471821425/npm-package-wrangler-2914 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4471821425/npm-package-cloudflare-pages-shared-2914

Note that these links will no longer work once the GitHub Actions artifact expires.

Add support for adding send email bindings to worker scripts. These
bindings can have 3 different types:
- Unrestricted
- Targeted
- Allowlist
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #2914 (ccafeb6) into main (9fa6b16) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2914      +/-   ##
==========================================
- Coverage   74.05%   74.03%   -0.03%     
==========================================
  Files         167      167              
  Lines       10419    10449      +30     
  Branches     2786     2798      +12     
==========================================
+ Hits         7716     7736      +20     
- Misses       2703     2713      +10     
Impacted Files Coverage Δ
...ler/src/api/pages/create-worker-bundle-contents.ts 100.00% <ø> (ø)
packages/wrangler/src/dev.tsx 85.00% <ø> (ø)
packages/wrangler/src/publish/publish.ts 87.43% <ø> (ø)
packages/wrangler/src/secret/index.ts 86.46% <ø> (ø)
packages/wrangler/src/worker.ts 100.00% <ø> (ø)
packages/wrangler/src/config/index.ts 92.56% <14.28%> (-3.89%) ⬇️
packages/wrangler/src/create-worker-upload-form.ts 89.09% <33.33%> (-1.57%) ⬇️
packages/wrangler/src/config/validation.ts 91.14% <90.00%> (-0.04%) ⬇️

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but I'd like at least one more fromDevProd to check it too.

@edevil
Copy link
Contributor Author

edevil commented Mar 21, 2023

Hey @mrbbot, mind adding a review? :)

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! ✅

@edevil
Copy link
Contributor Author

edevil commented Mar 21, 2023

Nice! Can we merge?

@petebacondarwin petebacondarwin merged commit 9af1a64 into cloudflare:main Mar 21, 2023
@github-actions github-actions bot mentioned this pull request Mar 21, 2023
@edevil
Copy link
Contributor Author

edevil commented Mar 21, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants