Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect querystring params passed to .fetch exposed by unstable_dev #2957

Merged
merged 4 commits into from
Apr 3, 2023

Conversation

esimons
Copy link
Contributor

@esimons esimons commented Mar 28, 2023

Fixes #2641

What this PR solves / how to test:

Respects querystring params passed to .fetch exposed by unstable_dev.

Associated docs issue(s)/PR(s):

Author has included the following, where applicable:

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@esimons esimons requested a review from a team as a code owner March 28, 2023 21:45
@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

🦋 Changeset detected

Latest commit: 11d8287

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@esimons esimons changed the title Wrangler api querystring Respect querystring params passed to .fetch exposed by unstable_dev Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #2957 (11d8287) into main (0a77990) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2957      +/-   ##
==========================================
+ Coverage   73.54%   73.57%   +0.02%     
==========================================
  Files         167      167              
  Lines       10499    10496       -3     
  Branches     2807     2805       -2     
==========================================
  Hits         7722     7722              
+ Misses       2777     2774       -3     
Impacted Files Coverage Δ
packages/wrangler/src/api/dev.ts 58.88% <100.00%> (-1.33%) ⬇️

... and 2 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4564493035/npm-package-wrangler-2957

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2957/npm-package-wrangler-2957

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4564493035/npm-package-wrangler-2957 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4564493035/npm-package-cloudflare-pages-shared-2957

Note that these links will no longer work once the GitHub Actions artifact expires.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this fix @esimons - I made a couple of suggestions. What do you think?

packages/wrangler/src/api/dev.ts Outdated Show resolved Hide resolved
packages/wrangler/src/api/dev.ts Outdated Show resolved Hide resolved
@esimons
Copy link
Contributor Author

esimons commented Apr 3, 2023

Hey @petebacondarwin! Happy Monday, and thanks for the review and feedback on this change, really appreciate it!

Do you have a guess for when this might be merged / published in a new release to npm? And/or how long the prerelease artifacts are retained? (No pressure on getting this out, I'm just referencing the prerelease in my CI tests and want to make sure I plan around those artifacts aging out.)

@petebacondarwin petebacondarwin merged commit 084b2c5 into cloudflare:main Apr 3, 2023
@petebacondarwin
Copy link
Contributor

Cool. Merged it. You should see this very soon on the beta dist-tag and as part of the next patch release - probably this week.

@esimons esimons deleted the wrangler-api-querystring branch April 3, 2023 16:32
@github-actions github-actions bot mentioned this pull request Apr 6, 2023
@JacobMGEvans JacobMGEvans mentioned this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🐛 BUG: unstable_dev fetch cannot accept query param
2 participants