-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect querystring params passed to .fetch
exposed by unstable_dev
#2957
Respect querystring params passed to .fetch
exposed by unstable_dev
#2957
Conversation
🦋 Changeset detectedLatest commit: 11d8287 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
.fetch
exposed by unstable_dev
Codecov Report
@@ Coverage Diff @@
## main #2957 +/- ##
==========================================
+ Coverage 73.54% 73.57% +0.02%
==========================================
Files 167 167
Lines 10499 10496 -3
Branches 2807 2805 -2
==========================================
Hits 7722 7722
+ Misses 2777 2774 -3
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4564493035/npm-package-wrangler-2957 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2957/npm-package-wrangler-2957 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4564493035/npm-package-wrangler-2957 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4564493035/npm-package-cloudflare-pages-shared-2957 Note that these links will no longer work once the GitHub Actions artifact expires. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this fix @esimons - I made a couple of suggestions. What do you think?
Hey @petebacondarwin! Happy Monday, and thanks for the review and feedback on this change, really appreciate it! Do you have a guess for when this might be merged / published in a new release to npm? And/or how long the prerelease artifacts are retained? (No pressure on getting this out, I'm just referencing the prerelease in my CI tests and want to make sure I plan around those artifacts aging out.) |
Cool. Merged it. You should see this very soon on the |
Fixes #2641
What this PR solves / how to test:
Respects querystring params passed to
.fetch
exposed byunstable_dev
.Associated docs issue(s)/PR(s):
unstable_dev
fetch cannot accept query param #2641Author has included the following, where applicable:
Reviewer has performed the following, where applicable: