-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Durable Object dev registry websockets #2989
Conversation
🦋 Changeset detectedLatest commit: 818d688 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4610496025/npm-package-wrangler-2989 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2989/npm-package-wrangler-2989 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4610496025/npm-package-wrangler-2989 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4610496025/npm-package-cloudflare-pages-shared-2989 Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #2989 +/- ##
==========================================
+ Coverage 73.57% 73.60% +0.02%
==========================================
Files 167 167
Lines 10504 10504
Branches 2807 2807
==========================================
+ Hits 7728 7731 +3
+ Misses 2776 2773 -3 |
@@ -87,7 +87,7 @@ async function main() { | |||
id.toString() | |||
); | |||
|
|||
return fetch(request); | |||
return upgradingFetch(request); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is all it took ha? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup!
LGTM. I'd maaaaybe hold off until Kevin confirms this fixes the issues he encountered as well, but your call |
Fixes #2676.
What this PR solves / how to test:
Author has included the following, where applicable:
Reviewer has performed the following, where applicable: