Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Durable Object dev registry websockets #2989

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

GregBrimble
Copy link
Member

Fixes #2676.

What this PR solves / how to test:

Author has included the following, where applicable:

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@GregBrimble GregBrimble requested a review from a team as a code owner April 4, 2023 17:16
@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2023

🦋 Changeset detected

Latest commit: 818d688

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4610496025/npm-package-wrangler-2989

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2989/npm-package-wrangler-2989

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4610496025/npm-package-wrangler-2989 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4610496025/npm-package-cloudflare-pages-shared-2989

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #2989 (818d688) into main (e311bbb) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2989      +/-   ##
==========================================
+ Coverage   73.57%   73.60%   +0.02%     
==========================================
  Files         167      167              
  Lines       10504    10504              
  Branches     2807     2807              
==========================================
+ Hits         7728     7731       +3     
+ Misses       2776     2773       -3     

see 2 files with indirect coverage changes

@@ -87,7 +87,7 @@ async function main() {
id.toString()
);

return fetch(request);
return upgradingFetch(request);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all it took ha? 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@CarmenPopoviciu
Copy link
Contributor

CarmenPopoviciu commented Apr 5, 2023

LGTM. I'd maaaaybe hold off until Kevin confirms this fixes the issues he encountered as well, but your call

@GregBrimble GregBrimble merged commit 86e942b into main Apr 11, 2023
11 checks passed
@GregBrimble GregBrimble deleted the fix-do-websockets branch April 11, 2023 12:08
@github-actions github-actions bot mentioned this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants