-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wrangler] teach wrangler to search docs #3004
Conversation
🦋 Changeset detectedLatest commit: 7505ced The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4741849025/npm-package-wrangler-3004 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3004/npm-package-wrangler-3004 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4741849025/npm-package-wrangler-3004 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4741849025/npm-package-cloudflare-pages-shared-3004 Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #3004 +/- ##
==========================================
- Coverage 74.40% 74.31% -0.10%
==========================================
Files 167 168 +1
Lines 10506 10530 +24
Branches 2807 2815 +8
==========================================
+ Hits 7817 7825 +8
- Misses 2689 2705 +16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am all for this once the security thing is cleared up or approved.
d50e04a
to
71ee52f
Compare
95254ad
to
e4bb817
Compare
14d03cc
to
cb621d9
Compare
bb8e0a4
to
e2c2da9
Compare
@@ -271,7 +271,7 @@ export function createCLIParser(argv: string[]) { | |||
|
|||
// docs | |||
wrangler.command( | |||
"docs [command]", | |||
"docs [command..]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GregBrimble I figured it out - this lets you have an optional command that takes an array
so wrangler docs pages astro
works now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe it was @WalshyDev, forgot which one I showed this to lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh hell yes. Ty Max!
Just awaiting the keys to be added to the Github secrets before this can be merged |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
a6deb2e
to
7505ced
Compare
I basically taught wrangler how to do a "I'm feeling lucky" search
How it works:
wrangler docs <command>
Here's what it looks like in action:
2022-12-07-quick-wins-3.mov
@rita3ko FYI