Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] teach wrangler to search docs #3004

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Apr 6, 2023

I basically taught wrangler how to do a "I'm feeling lucky" search

How it works:

Here's what it looks like in action:

2022-12-07-quick-wins-3.mov

@rita3ko FYI

@rozenmd rozenmd requested a review from a team as a code owner April 6, 2023 18:12
@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2023

🦋 Changeset detected

Latest commit: 7505ced

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rozenmd rozenmd self-assigned this Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4741849025/npm-package-wrangler-3004

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3004/npm-package-wrangler-3004

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4741849025/npm-package-wrangler-3004 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4741849025/npm-package-cloudflare-pages-shared-3004

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #3004 (7505ced) into main (5f48c40) will decrease coverage by 0.10%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3004      +/-   ##
==========================================
- Coverage   74.40%   74.31%   -0.10%     
==========================================
  Files         167      168       +1     
  Lines       10506    10530      +24     
  Branches     2807     2815       +8     
==========================================
+ Hits         7817     7825       +8     
- Misses       2689     2705      +16     
Impacted Files Coverage Δ
packages/wrangler/src/index.ts 84.46% <ø> (ø)
packages/wrangler/src/docs/index.ts 25.00% <9.09%> (-2.28%) ⬇️
packages/wrangler/src/docs/helpers.ts 14.28% <14.28%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am all for this once the security thing is cleared up or approved.

@rozenmd rozenmd force-pushed the teach-wrangler-to-search-docs branch from d50e04a to 71ee52f Compare April 7, 2023 05:22
@cloudflare cloudflare deleted a comment from gitguardian bot Apr 7, 2023
@rozenmd rozenmd force-pushed the teach-wrangler-to-search-docs branch from 95254ad to e4bb817 Compare April 17, 2023 17:36
@rozenmd rozenmd force-pushed the teach-wrangler-to-search-docs branch from 14d03cc to cb621d9 Compare April 18, 2023 13:14
.changeset/six-toes-yawn.md Outdated Show resolved Hide resolved
packages/wrangler/.gitguardian.yml Outdated Show resolved Hide resolved
packages/wrangler/src/docs/index.ts Outdated Show resolved Hide resolved
packages/wrangler/src/docs/index.ts Outdated Show resolved Hide resolved
packages/wrangler/src/docs/index.ts Outdated Show resolved Hide resolved
packages/wrangler/src/docs/index.ts Outdated Show resolved Hide resolved
packages/wrangler/src/docs/index.ts Outdated Show resolved Hide resolved
packages/wrangler/src/docs/index.ts Outdated Show resolved Hide resolved
packages/wrangler/src/docs/index.ts Outdated Show resolved Hide resolved
@rozenmd rozenmd force-pushed the teach-wrangler-to-search-docs branch from bb8e0a4 to e2c2da9 Compare April 18, 2023 15:18
@@ -271,7 +271,7 @@ export function createCLIParser(argv: string[]) {

// docs
wrangler.command(
"docs [command]",
"docs [command..]",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GregBrimble I figured it out - this lets you have an optional command that takes an array

so wrangler docs pages astro works now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe it was @WalshyDev, forgot which one I showed this to lol

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hell yes. Ty Max!

@rozenmd rozenmd requested a review from penalosa April 18, 2023 15:22
@cloudflare cloudflare deleted a comment from gitguardian bot Apr 18, 2023
@cloudflare cloudflare deleted a comment from gitguardian bot Apr 18, 2023
@rozenmd
Copy link
Contributor Author

rozenmd commented Apr 18, 2023

Just awaiting the keys to be added to the Github secrets before this can be merged

@gitguardian
Copy link

gitguardian bot commented Apr 18, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@rozenmd rozenmd force-pushed the teach-wrangler-to-search-docs branch from a6deb2e to 7505ced Compare April 19, 2023 09:41
@rozenmd rozenmd merged commit 6d5000a into main Apr 19, 2023
11 checks passed
@rozenmd rozenmd deleted the teach-wrangler-to-search-docs branch April 19, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants