Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] teach wrangler's D1 commands about config #3055

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Apr 17, 2023

What this PR solves / how to test:
D1 commands don't read from config - this is bad when a user has multiple accounts, and an account_id defined. wrangler publish for example handles this properly.

Author has included the following, where applicable:

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@rozenmd rozenmd requested a review from a team as a code owner April 17, 2023 13:48
@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2023

🦋 Changeset detected

Latest commit: 8c16347

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4723613142/npm-package-wrangler-3055

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3055/npm-package-wrangler-3055

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4723613142/npm-package-wrangler-3055 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4723613142/npm-package-cloudflare-pages-shared-3055

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #3055 (8c16347) into main (7930471) will increase coverage by 0.60%.
The diff coverage is 21.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3055      +/-   ##
==========================================
+ Coverage   73.84%   74.45%   +0.60%     
==========================================
  Files         167      167              
  Lines       10504    10506       +2     
  Branches     2807     2807              
==========================================
+ Hits         7757     7822      +65     
+ Misses       2747     2684      -63     
Impacted Files Coverage Δ
packages/wrangler/src/d1/backups.tsx 29.11% <0.00%> (+2.53%) ⬆️
packages/wrangler/src/d1/delete.ts 34.78% <0.00%> (ø)
packages/wrangler/src/d1/migrations/helpers.ts 94.64% <ø> (+30.35%) ⬆️
packages/wrangler/src/d1/create.tsx 45.00% <18.18%> (+8.15%) ⬆️
packages/wrangler/src/d1/list.tsx 32.25% <20.00%> (+5.59%) ⬆️
packages/wrangler/src/d1/execute.tsx 57.25% <100.00%> (+12.97%) ⬆️
packages/wrangler/src/d1/migrations/apply.tsx 60.46% <100.00%> (+22.09%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔬

@rozenmd rozenmd merged commit 5f48c40 into main Apr 17, 2023
11 checks passed
@rozenmd rozenmd deleted the rozenmd/use-wranglertoml-d1-commands branch April 17, 2023 16:58
@github-actions github-actions bot mentioned this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants