-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wrangler] Watch the entire module root + watch requirements.txt #5310
Conversation
🦋 Changeset detectedLatest commit: 93f592b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5310 +/- ##
==========================================
+ Coverage 72.16% 72.22% +0.05%
==========================================
Files 317 317
Lines 16372 16372
Branches 4169 4169
==========================================
+ Hits 11815 11824 +9
+ Misses 4557 4548 -9 |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-wrangler-5310 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5310/npm-package-wrangler-5310 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-wrangler-5310 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-create-cloudflare-5310 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-cloudflare-kv-asset-handler-5310 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-miniflare-5310 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-cloudflare-pages-shared-5310 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392727083/npm-package-cloudflare-vitest-pool-workers-5310 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's merge :)
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
6602432
to
79c9cc2
Compare
What this PR solves / how to test
In
--no-bundle
mode watch the entire module root for changes, rather than just the entrypoint file. Additionally, watch therequirements.txt
file for Python workers.Fixes EW-8223
Author has addressed the following