-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pages] Add wrangler pages config download
#5327
Conversation
🦋 Changeset detectedLatest commit: b5deb07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392679488/npm-package-wrangler-5327 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5327/npm-package-wrangler-5327 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392679488/npm-package-wrangler-5327 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392679488/npm-package-create-cloudflare-5327 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392679488/npm-package-cloudflare-kv-asset-handler-5327 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392679488/npm-package-miniflare-5327 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392679488/npm-package-cloudflare-pages-shared-5327 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8392679488/npm-package-cloudflare-vitest-pool-workers-5327 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5327 +/- ##
==========================================
+ Coverage 72.16% 72.39% +0.22%
==========================================
Files 317 318 +1
Lines 16372 16458 +86
Branches 4169 4201 +32
==========================================
+ Hits 11815 11914 +99
+ Misses 4557 4544 -13
|
@@ -45,6 +45,10 @@ export function Options(yargs: CommonYargsArgv) { | |||
type: "string", | |||
description: "The location for the output config file", | |||
}, | |||
"build-metadata-path": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for integration with CI—perhaps it shouldn't be in this PR
3af8b05
to
b5deb07
Compare
What this PR solves / how to test
Adds a Wrangler command to support downloading a Pages project's config into a
wrangler.toml
fileFixes DEVX-1178
Author has addressed the following