Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions rollback #5373

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Versions rollback #5373

merged 4 commits into from
Mar 26, 2024

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Mar 25, 2024

What this PR solves / how to test

CR: https://jira.cfdata.org/browse/CR-850334

This PR implements versioned rollbacks via wrangler rollback [version-id] --experimental-versions.

Please note, the experimental-versions flag is required to use the new behaviour and the original wrangler rollback command is unchanged if run without this flag.

Author has addressed the following

@RamIdeas RamIdeas requested a review from a team as a code owner March 25, 2024 19:58
Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: b0db6ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 25, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-wrangler-5373

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5373/npm-package-wrangler-5373

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-wrangler-5373 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-create-cloudflare-5373 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-cloudflare-kv-asset-handler-5373
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-miniflare-5373
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-cloudflare-pages-shared-5373
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-cloudflare-vitest-pool-workers-5373

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.38.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240320.0
workerd 1.20240320.1 1.20240320.1
workerd --version 1.20240320.1 2024-03-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 72.24%. Comparing base (7d160c7) to head (b0db6ad).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5373      +/-   ##
==========================================
- Coverage   72.29%   72.24%   -0.05%     
==========================================
  Files         318      321       +3     
  Lines       16458    16616     +158     
  Branches     4201     4253      +52     
==========================================
+ Hits        11898    12004     +106     
- Misses       4560     4612      +52     
Files Coverage Δ
packages/wrangler/src/index.ts 90.74% <100.00%> (+0.11%) ⬆️
packages/wrangler/src/versions/deploy.ts 92.47% <100.00%> (+0.12%) ⬆️
packages/wrangler/src/versions/deployments/list.ts 100.00% <100.00%> (ø)
...ckages/wrangler/src/versions/deployments/status.ts 97.61% <100.00%> (-0.30%) ⬇️
packages/wrangler/src/yargs-types.ts 100.00% <ø> (ø)
packages/wrangler/src/versions/rollback/index.ts 21.73% <21.73%> (ø)

... and 22 files with indirect coverage changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to explain what wrangler rollback [version-id] does here. I guess deploying with 100% of [version-id], or the last 100% version if [version-id] is omitted?

packages/wrangler/e2e/versions.test.ts Outdated Show resolved Hide resolved
packages/wrangler/e2e/versions.test.ts Outdated Show resolved Hide resolved
@RamIdeas RamIdeas merged commit 5bd8db8 into main Mar 26, 2024
17 checks passed
@RamIdeas RamIdeas deleted the versions-rollback branch March 26, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants