-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versions rollback #5373
Versions rollback #5373
Conversation
🦋 Changeset detectedLatest commit: b0db6ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-wrangler-5373 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5373/npm-package-wrangler-5373 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-wrangler-5373 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-create-cloudflare-5373 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-cloudflare-kv-asset-handler-5373 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-miniflare-5373 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-cloudflare-pages-shared-5373 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8440747875/npm-package-cloudflare-vitest-pool-workers-5373 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5373 +/- ##
==========================================
- Coverage 72.29% 72.24% -0.05%
==========================================
Files 318 321 +3
Lines 16458 16616 +158
Branches 4201 4253 +52
==========================================
+ Hits 11898 12004 +106
- Misses 4560 4612 +52
|
431da3a
to
6d0c846
Compare
6d0c846
to
57cf5df
Compare
.changeset/big-hounds-breathe.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be helpful to explain what wrangler rollback [version-id]
does here. I guess deploying with 100% of [version-id]
, or the last 100% version if [version-id]
is omitted?
57cf5df
to
0c5cd9b
Compare
What this PR solves / how to test
CR: https://jira.cfdata.org/browse/CR-850334
This PR implements versioned rollbacks via
wrangler rollback [version-id] --experimental-versions
.Please note, the
experimental-versions
flag is required to use the new behaviour and the originalwrangler rollback
command is unchanged if run without this flag.Author has addressed the following