Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log note of upcoming change of "Deployment ID" to "Version ID" #5400

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Mar 26, 2024

What this PR solves / how to test

CR: https://jira.cfdata.org/browse/CR-850334

Author has addressed the following

@RamIdeas RamIdeas requested a review from a team as a code owner March 26, 2024 20:54
Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: 64ed908

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 26, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-wrangler-5400

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5400/npm-package-wrangler-5400

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-wrangler-5400 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-create-cloudflare-5400 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-cloudflare-kv-asset-handler-5400
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-miniflare-5400
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-cloudflare-pages-shared-5400
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-cloudflare-vitest-pool-workers-5400

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.39.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240320.0
workerd 1.20240320.1 1.20240320.1
workerd --version 1.20240320.1 2024-03-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.28%. Comparing base (c99c7e2) to head (64ed908).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5400      +/-   ##
==========================================
+ Coverage   72.16%   72.28%   +0.11%     
==========================================
  Files         321      323       +2     
  Lines       16651    16673      +22     
  Branches     4258     4260       +2     
==========================================
+ Hits        12017    12052      +35     
+ Misses       4634     4621      -13     
Files Coverage Δ
packages/wrangler/src/deploy/deploy.ts 90.36% <100.00%> (+0.06%) ⬆️
packages/wrangler/src/deployments.ts 76.82% <100.00%> (+0.46%) ⬆️
...ngler/src/utils/deployment-id-version-id-change.ts 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

@RamIdeas RamIdeas force-pushed the versions-deployment-id-messaging branch from 36eeff3 to 8600662 Compare March 26, 2024 23:45
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the experimental versions flag is enabled, does this output already display Version ID rather than Deployment ID? That would seem like a good step for people opting into this new flow. If that is the case, then perhaps this message should only be displayed to people not opted-in?

@RamIdeas
Copy link
Contributor Author

If the experimental versions flag is enabled, does this output already display Version ID rather than Deployment ID? That would seem like a good step for people opting into this new flow. If that is the case, then perhaps this message should only be displayed to people not opted-in?

That is indeed the case. This message is logged in the old deployments list handler. The new handler – used if --x-versions is specified – omits Deployment IDs entirely and only shows Version IDs. You can try it now in the latest wrangler in the worker-app fixture: npx wrangler@latest deployments list --x-versions

@petebacondarwin
Copy link
Contributor

This needs to link to a LDW CR before we merge.

@RamIdeas
Copy link
Contributor Author

This needs to link to a LDW CR before we merge.

Thanks for the reminder! Added it to the description.

@RamIdeas RamIdeas merged commit c90dd6b into main Mar 28, 2024
17 checks passed
@RamIdeas RamIdeas deleted the versions-deployment-id-messaging branch March 28, 2024 14:32
@mrbbot mrbbot added the ldw-exempt PRs marked with this label can be included in releases during LDW. label Mar 28, 2024
@RamIdeas RamIdeas mentioned this pull request Mar 28, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ldw-exempt PRs marked with this label can be included in releases during LDW.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants