-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log note of upcoming change of "Deployment ID" to "Version ID" #5400
Conversation
🦋 Changeset detectedLatest commit: 64ed908 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-wrangler-5400 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5400/npm-package-wrangler-5400 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-wrangler-5400 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-create-cloudflare-5400 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-cloudflare-kv-asset-handler-5400 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-miniflare-5400 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-cloudflare-pages-shared-5400 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455856909/npm-package-cloudflare-vitest-pool-workers-5400 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5400 +/- ##
==========================================
+ Coverage 72.16% 72.28% +0.11%
==========================================
Files 321 323 +2
Lines 16651 16673 +22
Branches 4258 4260 +2
==========================================
+ Hits 12017 12052 +35
+ Misses 4634 4621 -13
|
36eeff3
to
8600662
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the experimental versions flag is enabled, does this output already display Version ID
rather than Deployment ID
? That would seem like a good step for people opting into this new flow. If that is the case, then perhaps this message should only be displayed to people not opted-in?
That is indeed the case. This message is logged in the old |
This needs to link to a LDW CR before we merge. |
Thanks for the reminder! Added it to the description. |
What this PR solves / how to test
CR: https://jira.cfdata.org/browse/CR-850334
Author has addressed the following