Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helpful logging to --experimental-versions commands #5419

Merged
merged 7 commits into from
Mar 28, 2024

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Mar 27, 2024

What this PR solves / how to test

This PR adds helpful logging to --experimental-versions commands.

The changes in packages/cli are a refactor and do not effect the output by default but now there are options to override the default formatting.

CR: https://jira.cfdata.org/browse/CR-850334

Author has addressed the following

defaults applied keep the output the same as before
we can change the defaults to be more sane in a follow-up after devweek
@RamIdeas RamIdeas requested a review from a team as a code owner March 27, 2024 20:30
Copy link

changeset-bot bot commented Mar 27, 2024

🦋 Changeset detected

Latest commit: 5f7ecb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 27, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-wrangler-5419

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5419/npm-package-wrangler-5419

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-wrangler-5419 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-create-cloudflare-5419 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-cloudflare-kv-asset-handler-5419
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-miniflare-5419
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-cloudflare-pages-shared-5419
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8466904788/npm-package-cloudflare-vitest-pool-workers-5419

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.39.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240320.0
workerd 1.20240320.1 1.20240320.1
workerd --version 1.20240320.1 2024-03-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 72.26%. Comparing base (7115568) to head (5f7ecb1).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5419      +/-   ##
==========================================
+ Coverage   72.19%   72.26%   +0.07%     
==========================================
  Files         322      322              
  Lines       16666    16670       +4     
  Branches     4260     4258       -2     
==========================================
+ Hits        12032    12047      +15     
+ Misses       4634     4623      -11     
Files Coverage Δ
packages/wrangler/src/deployments.ts 76.35% <ø> (ø)
packages/wrangler/src/versions/rollback/index.ts 21.73% <0.00%> (ø)
packages/wrangler/src/versions/upload.ts 11.50% <25.00%> (+0.27%) ⬆️

... and 8 files with indirect coverage changes

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Very minor non-blocking comments, but feel free to merge.

packages/cli/index.ts Outdated Show resolved Hide resolved
packages/wrangler/src/versions/upload.ts Outdated Show resolved Hide resolved
@RamIdeas RamIdeas merged commit daac6a2 into main Mar 28, 2024
17 checks passed
@RamIdeas RamIdeas deleted the versions-rollback-messaging branch March 28, 2024 19:29
@lrapoport-cf lrapoport-cf added the ldw-exempt PRs marked with this label can be included in releases during LDW. label Mar 28, 2024
RamIdeas added a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ldw-exempt PRs marked with this label can be included in releases during LDW.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants