Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D1] remove d1BetaWarning and all usages #5422

Merged
merged 3 commits into from
Mar 28, 2024
Merged

[D1] remove d1BetaWarning and all usages #5422

merged 3 commits into from
Mar 28, 2024

Conversation

geelen
Copy link
Contributor

@geelen geelen commented Mar 27, 2024

This PR removes the beta warning for D1.
LDW CR-851462

Author has addressed the following

Copy link

changeset-bot bot commented Mar 27, 2024

🦋 Changeset detected

Latest commit: 7b92b8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 27, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8467822345/npm-package-wrangler-5422

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5422/npm-package-wrangler-5422

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8467822345/npm-package-wrangler-5422 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8467822345/npm-package-create-cloudflare-5422 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8467822345/npm-package-cloudflare-kv-asset-handler-5422
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8467822345/npm-package-miniflare-5422
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8467822345/npm-package-cloudflare-pages-shared-5422
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8467822345/npm-package-cloudflare-vitest-pool-workers-5422

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.39.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240320.0
workerd 1.20240320.1 1.20240320.1
workerd --version 1.20240320.1 2024-03-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@geelen geelen changed the base branch from main to d1 March 28, 2024 11:39
@geelen geelen marked this pull request as ready for review March 28, 2024 11:39
@geelen geelen requested review from a team as code owners March 28, 2024 11:39
@rozenmd rozenmd changed the base branch from d1 to main March 28, 2024 12:32
@rozenmd rozenmd removed request for a team March 28, 2024 12:32
@cloudflare cloudflare deleted a comment from gitguardian bot Mar 28, 2024
@rozenmd rozenmd changed the title Removing d1BetaWarning and all usages [D1] remove d1BetaWarning and all usages Mar 28, 2024
Copy link

gitguardian bot commented Mar 28, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.27%. Comparing base (fbdca7d) to head (7b92b8a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5422      +/-   ##
==========================================
+ Coverage   72.20%   72.27%   +0.07%     
==========================================
  Files         322      322              
  Lines       16666    16660       -6     
  Branches     4258     4255       -3     
==========================================
+ Hits        12033    12041       +8     
+ Misses       4633     4619      -14     
Files Coverage Δ
packages/wrangler/src/d1/create.tsx 36.66% <ø> (-2.05%) ⬇️
packages/wrangler/src/d1/index.ts 88.23% <ø> (-0.66%) ⬇️
packages/wrangler/src/d1/info.tsx 19.64% <100.00%> (ø)
packages/wrangler/src/d1/insights.ts 19.04% <100.00%> (ø)
packages/wrangler/src/d1/utils.ts 100.00% <ø> (+3.44%) ⬆️
packages/wrangler/src/d1/delete.ts 37.50% <50.00%> (ø)
packages/wrangler/src/d1/list.tsx 67.74% <0.00%> (-1.01%) ⬇️
packages/wrangler/src/d1/options.ts 60.00% <50.00%> (ø)

... and 7 files with indirect coverage changes

@mrbbot mrbbot merged commit b341614 into main Mar 28, 2024
17 checks passed
@mrbbot mrbbot deleted the d1-out-of-beta branch March 28, 2024 13:47
@mrbbot mrbbot added the ldw-exempt PRs marked with this label can be included in releases during LDW. label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ldw-exempt PRs marked with this label can be included in releases during LDW.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants