New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wrangler): Updated Queues client to use new 'by-id' endpoints. #5477
feat(wrangler): Updated Queues client to use new 'by-id' endpoints. #5477
Conversation
🦋 Changeset detectedLatest commit: 6523f96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72ace63
to
49443d8
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-wrangler-5477 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5477/npm-package-wrangler-5477 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-wrangler-5477 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-create-cloudflare-5477 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-cloudflare-kv-asset-handler-5477 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-miniflare-5477 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-cloudflare-pages-shared-5477 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-cloudflare-vitest-pool-workers-5477 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
947be6d
to
9e5a769
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5477 +/- ##
==========================================
+ Coverage 72.44% 72.61% +0.17%
==========================================
Files 331 331
Lines 17298 17329 +31
Branches 4422 4425 +3
==========================================
+ Hits 12532 12584 +52
+ Misses 4766 4745 -21
|
14d7953
to
22ce85c
Compare
22ce85c
to
b5af9eb
Compare
b5af9eb
to
eb70ffe
Compare
589789b
to
e6b49c9
Compare
e6b49c9
to
cbd8419
Compare
cbd8419
to
f2d738c
Compare
LGTM. Have these changes been validated by someone on the queues team as well? |
7c36ebc
to
ad683c1
Compare
ad683c1
to
7be629e
Compare
packages/wrangler/src/queues/cli/commands/consumer/worker/remove.ts
Outdated
Show resolved
Hide resolved
921420f
to
6efd1f3
Compare
6efd1f3
to
6523f96
Compare
What this PR solves / how to test
Updates the Queues client to use new 'by-id' endpoints rather than the old 'by name' endpoints, which are in deprecation.
Fixes # MQ-553 internally
Author has addressed the following