Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wrangler): Updated Queues client to use new 'by-id' endpoints. #5477

Conversation

pmiguel
Copy link
Contributor

@pmiguel pmiguel commented Apr 2, 2024

What this PR solves / how to test

Updates the Queues client to use new 'by-id' endpoints rather than the old 'by name' endpoints, which are in deprecation.

Fixes # MQ-553 internally

Author has addressed the following

Copy link

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: 6523f96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pmiguel pmiguel force-pushed the pleal/new-queue-config-plane-endpoints branch from 72ace63 to 49443d8 Compare April 2, 2024 17:22
Copy link
Contributor

github-actions bot commented Apr 2, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-wrangler-5477

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5477/npm-package-wrangler-5477

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-wrangler-5477 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-create-cloudflare-5477 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-cloudflare-kv-asset-handler-5477
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-miniflare-5477
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-cloudflare-pages-shared-5477
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8663416139/npm-package-cloudflare-vitest-pool-workers-5477

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.50.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240405.1
workerd 1.20240405.0 1.20240405.0
workerd --version 1.20240405.0 2024-04-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@pmiguel pmiguel force-pushed the pleal/new-queue-config-plane-endpoints branch 4 times, most recently from 947be6d to 9e5a769 Compare April 3, 2024 16:08
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 96.26168% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 72.61%. Comparing base (2789f26) to head (589789b).
Report is 25 commits behind head on main.

❗ Current head 589789b differs from pull request most recent head 6523f96. Consider uploading reports for the commit 6523f96 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5477      +/-   ##
==========================================
+ Coverage   72.44%   72.61%   +0.17%     
==========================================
  Files         331      331              
  Lines       17298    17329      +31     
  Branches     4422     4425       +3     
==========================================
+ Hits        12532    12584      +52     
+ Misses       4766     4745      -21     
Files Coverage Δ
...ler/src/queues/cli/commands/consumer/worker/add.ts 100.00% <100.00%> (ø)
.../src/queues/cli/commands/consumer/worker/remove.ts 100.00% <100.00%> (ø)
packages/wrangler/src/deploy/deploy.ts 93.59% <92.85%> (+0.18%) ⬆️
.../src/queues/cli/commands/consumer/http-pull/add.ts 95.00% <91.66%> (+0.88%) ⬆️
packages/wrangler/src/queues/client.ts 97.95% <98.55%> (+1.08%) ⬆️
packages/wrangler/src/versions/upload.ts 11.94% <0.00%> (+0.28%) ⬆️

... and 7 files with indirect coverage changes

@pmiguel pmiguel force-pushed the pleal/new-queue-config-plane-endpoints branch 2 times, most recently from 14d7953 to 22ce85c Compare April 3, 2024 16:45
@pmiguel pmiguel changed the title chore(wrangler): Updated Queues client to use new 'by-id' endpoints. feat(wrangler): Updated Queues client to use new 'by-id' endpoints. Apr 3, 2024
@pmiguel pmiguel force-pushed the pleal/new-queue-config-plane-endpoints branch from 22ce85c to b5af9eb Compare April 3, 2024 17:08
@pmiguel pmiguel force-pushed the pleal/new-queue-config-plane-endpoints branch from b5af9eb to eb70ffe Compare April 4, 2024 10:26
@pmiguel pmiguel requested a review from mattdeboard April 4, 2024 11:35
@pmiguel pmiguel force-pushed the pleal/new-queue-config-plane-endpoints branch 7 times, most recently from 589789b to e6b49c9 Compare April 9, 2024 15:20
@pmiguel pmiguel marked this pull request as ready for review April 9, 2024 15:20
@pmiguel pmiguel requested a review from a team as a code owner April 9, 2024 15:20
@pmiguel pmiguel force-pushed the pleal/new-queue-config-plane-endpoints branch from e6b49c9 to cbd8419 Compare April 9, 2024 15:28
@pmiguel pmiguel marked this pull request as draft April 9, 2024 15:31
@pmiguel pmiguel force-pushed the pleal/new-queue-config-plane-endpoints branch from cbd8419 to f2d738c Compare April 10, 2024 09:38
@pmiguel pmiguel marked this pull request as ready for review April 11, 2024 09:24
@CarmenPopoviciu
Copy link
Contributor

LGTM. Have these changes been validated by someone on the queues team as well?

@pmiguel pmiguel force-pushed the pleal/new-queue-config-plane-endpoints branch 4 times, most recently from 7c36ebc to ad683c1 Compare April 11, 2024 11:09
@pmiguel pmiguel force-pushed the pleal/new-queue-config-plane-endpoints branch from ad683c1 to 7be629e Compare April 11, 2024 16:09
@pmiguel pmiguel force-pushed the pleal/new-queue-config-plane-endpoints branch 4 times, most recently from 921420f to 6efd1f3 Compare April 12, 2024 12:49
@pmiguel pmiguel force-pushed the pleal/new-queue-config-plane-endpoints branch from 6efd1f3 to 6523f96 Compare April 12, 2024 14:11
@CarmenPopoviciu CarmenPopoviciu merged commit 9a46e03 into cloudflare:main Apr 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants