Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] mark ts-json-schema-generator as a dev dependency #5610

Conversation

SuperchupuDev
Copy link
Contributor

What this PR solves / how to test

Fixes #5609

Author has addressed the following

@SuperchupuDev SuperchupuDev requested a review from a team as a code owner April 13, 2024 19:27
Copy link

changeset-bot bot commented Apr 13, 2024

🦋 Changeset detected

Latest commit: 84b7627

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8675775722/npm-package-wrangler-5610

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5610/npm-package-wrangler-5610

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8675775722/npm-package-wrangler-5610 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8675775722/npm-package-create-cloudflare-5610 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8675775722/npm-package-cloudflare-kv-asset-handler-5610
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8675775722/npm-package-miniflare-5610
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8675775722/npm-package-cloudflare-pages-shared-5610
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8675775722/npm-package-cloudflare-vitest-pool-workers-5610

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.50.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240405.1
workerd 1.20240405.0 1.20240405.0
workerd --version 1.20240405.0 2024-04-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@penalosa penalosa merged commit 24840f6 into cloudflare:main Apr 18, 2024
15 checks passed
@SuperchupuDev SuperchupuDev deleted the fix/ts-json-schema-generator-dev-dependency branch April 18, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🐛 BUG: dev dependency ts-json-schema-generator set as production dependency
2 participants