Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃憖 Bundle manifests #5659

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

馃憖 Bundle manifests #5659

wants to merge 1 commit into from

Conversation

GregBrimble
Copy link
Member

@GregBrimble GregBrimble commented Apr 19, 2024

What this PR solves / how to test

Hack Week prototype.

Allows you to define, in modules, other modules which should be picked up by Wrangler when it constructs its bundle. This is useful for lazy-loading boundaries and assets! I have needed this multiple times in the past, particularly when writing libraries (you don't want your users to have to copy-paste files around or put stuff in [[rules]] just for you).

"use wrangler bundle ./assets/**/* Data";

Happy to bike-shed on the exact way to define these things.

An open question: should it be limited to only child dirs? Or have some sort of user acknowledgement? I could see a concern around a lib sneakily including /etc/passwd in a bundle or something. That's already doable today for any file which matches a rule but this just makes it that much easier to grab files.

Author has addressed the following

Copy link

changeset-bot bot commented Apr 19, 2024

鈿狅笍 No Changeset found

Latest commit: 9d90c00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8748491477/npm-package-wrangler-5659

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5659/npm-package-wrangler-5659

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8748491477/npm-package-wrangler-5659 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8748491477/npm-package-create-cloudflare-5659 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8748491477/npm-package-cloudflare-kv-asset-handler-5659
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8748491477/npm-package-miniflare-5659
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8748491477/npm-package-cloudflare-pages-shared-5659
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8748491477/npm-package-cloudflare-vitest-pool-workers-5659

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.51.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240405.2
workerd 1.20240405.0 1.20240405.0
workerd --version 1.20240405.0 2024-04-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

None yet

1 participant