Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workers ai staging flag #5705

Merged
merged 5 commits into from Apr 29, 2024
Merged

Conversation

G4brym
Copy link
Member

@G4brym G4brym commented Apr 24, 2024

What this PR solves / how to test

This adds support for staging flag for Ai binding, this binding only works in specific workers.
For normal users trying to use it, the flag will be ignored.

Author has addressed the following

Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: 0e5133e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@G4brym G4brym force-pushed the add-ai-staging-flag branch 2 times, most recently from bd37bf3 to 520ea74 Compare April 24, 2024 17:17
Copy link
Contributor

github-actions bot commented Apr 24, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8861024255/npm-package-wrangler-5705

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5705/npm-package-wrangler-5705

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8861024255/npm-package-wrangler-5705 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8861024255/npm-package-create-cloudflare-5705 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8861024255/npm-package-cloudflare-kv-asset-handler-5705
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8861024255/npm-package-miniflare-5705
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8861024255/npm-package-cloudflare-pages-shared-5705
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8861024255/npm-package-cloudflare-vitest-pool-workers-5705

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.52.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240419.0
workerd 1.20240419.0 1.20240419.0
workerd --version 1.20240419.0 2024-04-19

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@G4brym G4brym force-pushed the add-ai-staging-flag branch 4 times, most recently from dbc080c to d175b60 Compare April 24, 2024 18:35
@G4brym G4brym marked this pull request as ready for review April 24, 2024 18:43
@G4brym G4brym requested a review from a team as a code owner April 24, 2024 18:43
@@ -111,6 +111,7 @@ export interface CfBrowserBinding {

export interface CfAIBinding {
binding: string;
staging?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to mark this with a JSDoc @internal attribute or some other way to clarify to external users that they shouldn't use this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have first_party_worker, logfwdr and unsafe bindings so no need to block this PR now. We can follow up later if this is applicable.

@G4brym
Copy link
Member Author

G4brym commented Apr 29, 2024

The builds have now passed successfully, and we have tested this locally and is working, can you @RamIdeas merge this pr?

@RamIdeas RamIdeas merged commit 4097759 into cloudflare:main Apr 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants