-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C3] Framework migration diffs #5716
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-wrangler-5716 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5716/npm-package-wrangler-5716 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-wrangler-5716 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-create-cloudflare-5716 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-cloudflare-kv-asset-handler-5716 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-miniflare-5716 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-cloudflare-pages-shared-5716 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9160932365/npm-package-cloudflare-vitest-pool-workers-5716 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me 😃
I've added a few comments though, please have a look 🙏
030cbe6
to
61efea4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! thanks a lot for addressing my comments 🚀 😄
7601ee8
to
19873f5
Compare
19873f5
to
4fabcce
Compare
What this PR solves / how to test
When running c3 e2e tests on the release branch, this change will store the diff between what is created by framework scaffolding tools and the parts which C3 layers on top. This is only done for full-stack framework templates In doing so, this will create a rough guide for users on how to migrate existing apps.
The result will be saved as an artifact, and once a release is successfully published, a PR will be created to the cloudflare-docs repo with the result.
Author has addressed the following