Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate duplicate bindings across all binding types #5737

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented May 1, 2024

What this PR solves / how to test

Fixes #2893

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: behaviour already tested, this PR just adds it to more bindings (and adds a type level to check to make sure this doesn't regress)
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

Copy link

changeset-bot bot commented May 1, 2024

⚠️ No Changeset found

Latest commit: cd5eb7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 1, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-wrangler-5737

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5737/npm-package-wrangler-5737

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-wrangler-5737 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-create-cloudflare-5737 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-cloudflare-kv-asset-handler-5737
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-miniflare-5737
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-cloudflare-pages-shared-5737
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9064050616/npm-package-cloudflare-vitest-pool-workers-5737

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.55.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240419.1
workerd 1.20240419.0 1.20240419.0
workerd --version 1.20240419.0 2024-04-19

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa force-pushed the 2893-bug-same-name-for-the-kv-and-queue-bindings-generates-internal-server-error-10002 branch from 11deac5 to cd5eb7a Compare May 1, 2024 17:33
@penalosa penalosa closed this May 13, 2024
@penalosa penalosa reopened this May 13, 2024
])
);

console.log(bindingsGroupedByType);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this log needed here?

@CarmenPopoviciu
Copy link
Contributor

this LGTM. Left a small comment + don't forget about adding a changeset. Otherwise, good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

🐛 BUG: same name for the KV and Queue bindings generates internal server error (10002)
2 participants