Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent spaces in names #5738

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented May 1, 2024

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

@penalosa penalosa requested a review from a team as a code owner May 1, 2024 17:47
@penalosa penalosa linked an issue May 1, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented May 1, 2024

⚠️ No Changeset found

Latest commit: 4c19481

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 1, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8912873355/npm-package-wrangler-5738

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5738/npm-package-wrangler-5738

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8912873355/npm-package-wrangler-5738 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8912873355/npm-package-create-cloudflare-5738 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8912873355/npm-package-cloudflare-kv-asset-handler-5738
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8912873355/npm-package-miniflare-5738
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8912873355/npm-package-cloudflare-pages-shared-5738
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8912873355/npm-package-cloudflare-vitest-pool-workers-5738

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.53.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240419.0
workerd 1.20240419.0 1.20240419.0
workerd --version 1.20240419.0 2024-04-19

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin marked this pull request as draft May 13, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: websocket connection closed before connection established
1 participant