Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Version ID to all outputs in addition to the deprecated Deployment ID #5740

Merged
merged 1 commit into from
May 7, 2024

Conversation

WalshyDev
Copy link
Member

@WalshyDev WalshyDev commented May 1, 2024

What this PR solves / how to test

Fixes WC-2110

We need the version ID in the output so users can migrate before we fully remove it.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

@WalshyDev WalshyDev requested a review from a team as a code owner May 1, 2024 19:05
Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: 7892e30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 1, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8939488743/npm-package-wrangler-5740

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5740/npm-package-wrangler-5740

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8939488743/npm-package-wrangler-5740 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8939488743/npm-package-create-cloudflare-5740 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8939488743/npm-package-cloudflare-kv-asset-handler-5740
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8939488743/npm-package-miniflare-5740
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8939488743/npm-package-cloudflare-pages-shared-5740
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8939488743/npm-package-cloudflare-vitest-pool-workers-5740

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.53.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240419.0
workerd 1.20240419.0 1.20240419.0
workerd --version 1.20240419.0 2024-04-19

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

@tanushree-sharma tanushree-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New copy looks good!

@RamIdeas RamIdeas merged commit 97741db into main May 7, 2024
12 checks passed
@RamIdeas RamIdeas deleted the walshy/add-version-id branch May 7, 2024 14:00
@workers-devprod workers-devprod mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants