Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suggest trying to update Wrangler if there is a newer one available after an unexpected error #5746

Merged
merged 1 commit into from May 2, 2024

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented May 2, 2024

What this PR solves / how to test

Fixes DEVX-543

Author has addressed the following

@petebacondarwin petebacondarwin requested a review from a team as a code owner May 2, 2024 14:50
Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: 8b7cd82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 2, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8925891793/npm-package-wrangler-5746

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5746/npm-package-wrangler-5746

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8925891793/npm-package-wrangler-5746 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8925891793/npm-package-create-cloudflare-5746 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8925891793/npm-package-cloudflare-kv-asset-handler-5746
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8925891793/npm-package-miniflare-5746
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8925891793/npm-package-cloudflare-pages-shared-5746
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8925891793/npm-package-cloudflare-vitest-pool-workers-5746

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.53.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240419.0
workerd 1.20240419.0 1.20240419.0
workerd --version 1.20240419.0 2024-04-19

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin changed the title fix: suggest trying to update Wrangler if there is a newer one availa… fix: suggest trying to update Wrangler if there is a newer one available after an unexpected error May 2, 2024
@petebacondarwin petebacondarwin added the e2e Run e2e tests on a PR label May 2, 2024
@penalosa penalosa merged commit 1dd9f7e into main May 2, 2024
17 checks passed
@penalosa penalosa deleted the update-fatal-error branch May 2, 2024 15:55
@workers-devprod workers-devprod mentioned this pull request May 2, 2024
Copy link
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants