Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper type for AI binding in wrangler types #5758

Merged

Conversation

Jackenmen
Copy link
Contributor

@Jackenmen Jackenmen commented May 4, 2024

What this PR solves / how to test

This PR updates Wrangler CLI to use Ai type for the AI binding.

Author has addressed the following

@Jackenmen Jackenmen requested review from a team as code owners May 4, 2024 18:25
Copy link

changeset-bot bot commented May 4, 2024

🦋 Changeset detected

Latest commit: 5b0aaa9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 10, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9196611725/npm-package-wrangler-5758

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5758/npm-package-wrangler-5758

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9196611725/npm-package-wrangler-5758 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9196611725/npm-package-create-cloudflare-5758 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9196611725/npm-package-cloudflare-kv-asset-handler-5758
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9196611725/npm-package-miniflare-5758
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9196611725/npm-package-cloudflare-pages-shared-5758
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9196611725/npm-package-cloudflare-vitest-pool-workers-5758

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.57.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240512.0
workerd 1.20240512.0 1.20240512.0
workerd --version 1.20240512.0 2024-05-12

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin
Copy link
Contributor

This PR is blocked until we update workerd which itself is blocked on a new release of workerd due today.

@petebacondarwin petebacondarwin added the blocked Blocked on other work label May 13, 2024
@petebacondarwin
Copy link
Contributor

Please can you rebase on top of main now that we have updated the workerd version.

@petebacondarwin petebacondarwin removed the blocked Blocked on other work label May 14, 2024
@Jackenmen Jackenmen force-pushed the use_proper_type_hints_for_ai_binding branch from ac22a0f to 5b0aaa9 Compare May 14, 2024 19:55
@Jackenmen
Copy link
Contributor Author

Done!

@penalosa penalosa closed this May 22, 2024
@penalosa penalosa reopened this May 22, 2024
@CarmenPopoviciu CarmenPopoviciu merged commit 8e5e589 into cloudflare:main May 30, 2024
37 checks passed
@Jackenmen Jackenmen deleted the use_proper_type_hints_for_ai_binding branch May 30, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants