-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Hyperdrive warning log indicating that Hyperdrive local binding does not work #5812
Remove Hyperdrive warning log indicating that Hyperdrive local binding does not work #5812
Conversation
…g does not work Description Hyperdrive is supported locally (see cloudflare/workerd#1266) and this warning is not longer accurate. It was added while the support was in progress to avoid confusion (cloudflare@54800f6), but now that local support for Hyperdrive bindings has been added, this log is incorrect and should be removed
🦋 Changeset detectedLatest commit: d69ffaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Matt <granjef3@gmail.com>
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-wrangler-5812 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5812/npm-package-wrangler-5812 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-wrangler-5812 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-create-cloudflare-5812 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-cloudflare-kv-asset-handler-5812 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-miniflare-5812 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-cloudflare-pages-shared-5812 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-cloudflare-vitest-pool-workers-5812 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
.changeset/thirty-kings-serve.md
Outdated
"wrangler": patch | ||
--- | ||
|
||
Update Hyperdrive logs to reflect that hyperdrive bindings are now supported in local dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use the recommended changeset message format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarmenPopoviciu good to merge now?
@thomasgauvin has support for Hyperdrive been added to Miniflare? |
It's been in miniflare/workerd for a while now |
Thanks for confirming @xortive, I'll be fixing the changeset as per template @CarmenPopoviciu |
Hyperdrive is supported locally (see cloudflare/workerd#1266) and this warning is not longer accurate. It was added while the support was in progress to avoid confusion (54800f6), but now that local support for Hyperdrive bindings has been added, this log is incorrect and should be removed
Author has addressed the following