Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hyperdrive warning log indicating that Hyperdrive local binding does not work #5812

Conversation

thomasgauvin
Copy link
Contributor

Hyperdrive is supported locally (see cloudflare/workerd#1266) and this warning is not longer accurate. It was added while the support was in progress to avoid confusion (54800f6), but now that local support for Hyperdrive bindings has been added, this log is incorrect and should be removed

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: This is a log bugfix that does not have implications on the functionality.
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: This is a log bugfix that does not have implications on the functionality, and warning logs are not verified in e2e tests.
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

…g does not work

Description Hyperdrive is supported locally (see cloudflare/workerd#1266) and this warning is not longer accurate. It was added while the support was in progress to avoid confusion (cloudflare@54800f6), but now that local support for Hyperdrive bindings has been added, this log is incorrect and should be removed
@thomasgauvin thomasgauvin requested a review from a team as a code owner May 13, 2024 15:23
Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: d69ffaf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.changeset/thirty-kings-serve.md Outdated Show resolved Hide resolved
Co-authored-by: Matt <granjef3@gmail.com>
Copy link
Contributor

github-actions bot commented May 13, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-wrangler-5812

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5812/npm-package-wrangler-5812

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-wrangler-5812 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-create-cloudflare-5812 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-cloudflare-kv-asset-handler-5812
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-miniflare-5812
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-cloudflare-pages-shared-5812
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9116045640/npm-package-cloudflare-vitest-pool-workers-5812

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.56.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240512.0
workerd 1.20240512.0 1.20240512.0
workerd --version 1.20240512.0 2024-05-12

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

"wrangler": patch
---

Update Hyperdrive logs to reflect that hyperdrive bindings are now supported in local dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the recommended changeset message format

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarmenPopoviciu good to merge now?

@penalosa
Copy link
Contributor

@thomasgauvin has support for Hyperdrive been added to Miniflare?

@xortive
Copy link
Contributor

xortive commented May 15, 2024

@thomasgauvin has support for Hyperdrive been added to Miniflare?

It's been in miniflare/workerd for a while now

@thomasgauvin
Copy link
Contributor Author

thomasgauvin commented May 16, 2024

Thanks for confirming @xortive, I'll be fixing the changeset as per template @CarmenPopoviciu

@petebacondarwin petebacondarwin merged commit d5e00e4 into cloudflare:main May 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants