Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate "deployment" in metadata binding #5818

Merged
merged 1 commit into from
May 16, 2024

Conversation

WalshyDev
Copy link
Member

@WalshyDev WalshyDev commented May 14, 2024

What this PR solves / how to test

WC-1755

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: Doesn't impact e2e tests
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

@WalshyDev WalshyDev requested a review from a team as a code owner May 14, 2024 08:51
Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: aaab82e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 14, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-wrangler-5818

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5818/npm-package-wrangler-5818

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-wrangler-5818 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-create-cloudflare-5818 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-cloudflare-kv-asset-handler-5818
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-miniflare-5818
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-cloudflare-pages-shared-5818
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9110913904/npm-package-cloudflare-vitest-pool-workers-5818

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.56.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240512.0
workerd 1.20240512.0 1.20240512.0
workerd --version 1.20240512.0 2024-05-12

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WalshyDev WalshyDev force-pushed the walshy/deprecate-metadata-binding branch from 5edc3de to 70ab7a0 Compare May 14, 2024 08:54
@WalshyDev WalshyDev force-pushed the walshy/deprecate-metadata-binding branch 3 times, most recently from 29ba36a to 3f724ff Compare May 14, 2024 10:20
@WalshyDev WalshyDev force-pushed the walshy/deprecate-metadata-binding branch 7 times, most recently from f0775ab to fe72cbf Compare May 16, 2024 09:42
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the docs on https://developers.cloudflare.com/workers/wrangler/configuration as well? There's no mention there of either the old metadata or the new version_metadata bindings. I am aware that https://developers.cloudflare.com/workers/runtime-apis/bindings/version-metadata exists, just calling it out

@WalshyDev WalshyDev force-pushed the walshy/deprecate-metadata-binding branch from fe72cbf to aaab82e Compare May 16, 2024 10:45
@WalshyDev
Copy link
Member Author

Should we update the docs on developers.cloudflare.com/workers/wrangler/configuration as well? There's no mention there of either the old metadata or the new version_metadata bindings. I am aware that developers.cloudflare.com/workers/runtime-apis/bindings/version-metadata exists, just calling it out

Yep good callout, will add there :)

@WalshyDev WalshyDev merged commit df2daf2 into main May 16, 2024
19 checks passed
@WalshyDev WalshyDev deleted the walshy/deprecate-metadata-binding branch May 16, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants