Node 18 #5820
Node 18 #5820
Conversation
|
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9094843173/npm-package-wrangler-5820You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5820/npm-package-wrangler-5820Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9094843173/npm-package-wrangler-5820 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9094843173/npm-package-create-cloudflare-5820 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9094843173/npm-package-cloudflare-kv-asset-handler-5820npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9094843173/npm-package-miniflare-5820npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9094843173/npm-package-cloudflare-pages-shared-5820npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9094843173/npm-package-cloudflare-vitest-pool-workers-5820Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16.18 | ||
| node-version: 18.20.2 |
There was a problem hiding this comment.
can we pin this to latest v18.x.x rather than the specific v18.20.2?
There was a problem hiding this comment.
I'm not keen on doing that because that means that running a build at two different times might have different results. I am also not worried about keeping on the leading edge given that we have spent the last year stuck on v16 😄
There was a problem hiding this comment.
In the pnpm PR that will follow this, I move all the dependency installations into a single common action so we only have to change the version in one place.
| @@ -1,6 +1,7 @@ | |||
| import { rest } from "msw"; | |||
| import { hasMorePages } from "../cfetch"; | |||
| import { mockAccountId, mockApiToken } from "./helpers/mock-account-id"; | |||
| import { mockConsoleMethods } from "./helpers/mock-console"; | |||
| import { createFetchResult, msw } from "./helpers/msw"; | |||
| import { runInTempDir } from "./helpers/run-in-tmp"; | |||
There was a problem hiding this comment.
The cleanup for this util is failing on windows again (resource lock) – I thought we solved that? (maybe by just wrapping in try..catch but that seemed fine)
There was a problem hiding this comment.
I've rerun the job anyway in case it was just a flake
The tests change files within the src directory, which was causing cache misses every time on builds
…issue When `wrangler dev` is run with `--port=0` workerd can get messed up on Node 18+ because it starts listening to both 127.0.0.1 and ::1 addresses with different dynamically assigned ports. The workaround is to always specify the IP address when setting port to 0.
What this PR solves / how to test
Updates the monorepo to support node 18.
Author has addressed the following