Updated types for 2022-04-13 #210
Conversation
🦋 Changeset detectedLatest commit: 7d6a53d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
WebSocket's are still missing from this release but otherwise should be OK to merge later this week. CC @harrishancock |
ObsidianMinor
force-pushed
the
update-types
branch
from
9848430
to
7d6a53d
Compare
ObsidianMinor
changed the title
| declare class ByteLengthQueuingStrategy { | ||
| constructor(init: QueuingStrategyInit); | ||
| readonly highWaterMark: number; | ||
| size(arg1?: any): number | undefined; |
There was a problem hiding this comment.
Nit: arg1 could have a nicer name
There was a problem hiding this comment.
cc @ObsidianMinor - can be updated for the next release.
| declare class CountQueuingStrategy { | ||
| constructor(init: QueuingStrategyInit); | ||
| readonly highWaterMark: number; | ||
| size(arg1?: any): number | undefined; |
There was a problem hiding this comment.
Nit: again, arg1 could have a nicer name
There was a problem hiding this comment.
cc @ObsidianMinor - can be updated for the next release
There was a problem hiding this comment.
Actually this is for @jasnell
| @@ -187,6 +193,10 @@ interface Comment { | |||
| remove(): Comment; | |||
| } | |||
|
|
|||
| declare class CompressionStream extends TransformStream { | |||
| constructor(format: string); | |||
There was a problem hiding this comment.
Nit: could be more specific, what formats are supported?
| constructor(format: string); | |
| constructor(format: "gzip" | "deflate"); |
There was a problem hiding this comment.
CC @jasnell. Would be for next release not this one.
| @@ -306,6 +322,10 @@ declare class DOMException extends Error { | |||
| static readonly DATA_CLONE_ERR: number; | |||
| } | |||
|
|
|||
| declare class DecompressionStream extends TransformStream { | |||
| constructor(format: string); | |||
There was a problem hiding this comment.
Nit: again, what formats are supported?
| constructor(format: string); | |
| constructor(format: "gzip" | "deflate"); |
There was a problem hiding this comment.
cc @jasnell - not blocking this release.
There was a problem hiding this comment.
Will make a note to update this in the overrides for next release.
| @@ -399,24 +428,26 @@ interface DurableObjectStorage { | |||
| transaction<T>( | |||
| closure: (txn: DurableObjectTransaction) => Promise<T> | |||
| ): Promise<T>; | |||
| getAlarm(options?: DurableObjectGetAlarmOptions): Promise<Date | null>; | |||
| setAlarm(arg2: Date, options?: DurableObjectSetAlarmOptions): Promise<void>; | |||
There was a problem hiding this comment.
Nit: arg2 could have a nicer name (kinda confused why this is arg2 not arg1 😅)
There was a problem hiding this comment.
cc @ObsidianMinor - not blocking
| @@ -446,6 +477,8 @@ interface DurableObjectTransaction { | |||
| delete(key: string, options?: DurableObjectPutOptions): Promise<boolean>; | |||
| delete(keys: string[], options?: DurableObjectPutOptions): Promise<number>; | |||
| rollback(): void; | |||
| getAlarm(options?: DurableObjectGetAlarmOptions): Promise<Date | null>; | |||
| setAlarm(arg2: Date, options?: DurableObjectSetAlarmOptions): Promise<void>; | |||
There was a problem hiding this comment.
Nit: again arg2 could have a nicer name
There was a problem hiding this comment.
cc @ObsidianMinor - not blocking
| get(key: string, options?: R2GetOptions): Promise<R2ObjectBody | null>; | ||
| put( | ||
| key: string, | ||
| value: ReadableStream | ArrayBuffer | ArrayBufferView | string | null, |
There was a problem hiding this comment.
Yup - will fix it for next release. You can actually pass in a blob, it's just the type signature is wrong.
| @@ -1495,7 +1665,10 @@ declare class TextDecoder { | |||
| label?: "utf-8" | "utf8" | "unicode-1-1-utf-8", | |||
There was a problem hiding this comment.
As of 2022/2/25, TextDecoder supports the full range of encodings. Presumably TextEncoder does too?
| label?: "utf-8" | "utf8" | "unicode-1-1-utf-8", | |
| label?: string, |
There was a problem hiding this comment.
Yes, but... TextEncoder only supports UTF-8. It does not have a label argument.
There was a problem hiding this comment.
I think TextDecoder needs to have the override removed for the label maybe since we support all of the standard labels?
|
Nothing blocking identified. Merging. |
This PR includes the auto-generated types generated on
2022-04-13.