Updated types for 2022-04-27 #226
Conversation
🦋 Changeset detectedLatest commit: a18ca78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| setAlarm( | ||
| arg2: Date, | ||
| options?: DurableObjectStorageOperationsSetAlarmOptions | ||
| scheduledTime: Date, |
There was a problem hiding this comment.
Is this right? getAlarm returns a number, but setAlarm takes a Date? Should setAlarm take number | Date?
There was a problem hiding this comment.
setAlarm does take number | Date, I guess we need to update the type generation script to understand this
There was a problem hiding this comment.
setAlarm(kj::Date scheduledTime
Are you sure about that Matt? The type generation script is pretty stable.
There was a problem hiding this comment.
Is there a reason we don't return a Date from getAlarm?
There was a problem hiding this comment.
setAlarm(kj::Date scheduledTimeAre you sure about that Matt? The type generation script is pretty stable.
It's possible CFJS automatically casts numbers to kj::Dates?
There was a problem hiding this comment.
I think that Brendan's observation is valid. This API is asymmetric which is odd.
@xortive could you see what's causing this and see if we can fix it? thank you
| setAlarm( | ||
| arg2: Date, | ||
| options?: DurableObjectStorageOperationsSetAlarmOptions | ||
| scheduledTime: Date, |
There was a problem hiding this comment.
Again, should this be number | Date?
|
Going to merge this because conversation is about API which isn't a great forum because this project represents the current state of the runtime and the types generated are actually correct. |
This PR includes the auto-generated types generated on
2022-04-27.