Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added memoiser and refactored out Get instance calls #825

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Added memoiser and refactored out Get instance calls #825

merged 1 commit into from
Aug 17, 2022

Conversation

KevinJCross
Copy link
Contributor

  • added mocks
  • factored out the gets
  • Refactored out the get inteface calls and added a memoiser

@KevinJCross KevinJCross added chore allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. and removed allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. labels Aug 16, 2022
@KevinJCross KevinJCross force-pushed the v3_service_plans branch 2 times, most recently from aa682ce to 07d2091 Compare August 17, 2022 09:11
silvestre
silvestre reviewed Aug 17, 2022
View reviewed changes
Makefile Show resolved Hide resolved
src/autoscaler/cf/memoizer.go Show resolved Hide resolved
src/autoscaler/cf/service_plans.go Show resolved Hide resolved
@silvestre
Copy link
Member

Cool stuff!

@KevinJCross KevinJCross merged commit e233125 into main Aug 17, 2022
@KevinJCross KevinJCross deleted the v3_service_plans branch August 17, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvestre silvestre silvestre left review comments

@asalan316 asalan316 asalan316 approved these changes

Assignees
No one assigned
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KevinJCross @silvestre @asalan316