chore: Regenerate protobuf code #375
Conversation
Prepending `code.cloudfoundry.org` generates the code automatically into `code.cloudfoundry.org/...`, which is not the path that we store the loggregator-agent-release repo at typically. If we remove it, the protobuf code generation step becomes a lot simpler. Besides, we weren't even adding that line to our package name in the generated files, so it's not very helpful. Better to have the path align with where we want the generated files to actually go.
|
@ctlong It looks like the doppler.proto here is really old: loggregator-agent-release/src/pkg/plumbing/doppler.proto Lines 55 to 69 in 96d62c7 What do you think about the current pattern where doppler.proto is duplicated in loggregator-release and here? |
|
@ctlong, @acrmp I don't know about the If we decide to remove them, we should do a proper deprecation process, so that everyone is informed, and make sure that the other protocol definitions are compatible with the older releases as one will have to pin the |
No description provided.