fix: Syslog Agent HTTPS drains reuse and release fasthttp requests and responses where appropriate #573
+149
−333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuses fasthttp requests and responses within the writer as appropriate, and releases them afterwards. Also includes some light refactoring for clarity. Signed-off-by: Carson Long <12767276+ctlong@users.noreply.github.com>
mkocher
force-pushed
the
fix/syslog-agent/https
branch
from
de8d260
to
bfb8d60
Compare
ctlong
changed the title
|
I want to run some manual tests on this before merging. |
|
I think this would help in many cases, but only if there are multiple messages present in one msgs batch. But that change would lead to more complicated request aquirations, so I am torn if that would help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syslog Agent uses fasthttp under the hood for HTTPS drains. When making HTTPS requests to drains to send syslog messages we use AcquireRequest and AcquireResponse, which we can reuse and eventually release.
Hopefully this change has a positive improvement on the performance of HTTPS drains.