Fix for page alert pointer-events issue #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1089138 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
spaceninja
approved these changes
Dec 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When our Page layout object has an alert, its container blocks clicks, text selections, etc. below.
This is an issue when an alert within is hidden but the element itself is not.
We could refactor our alert JavaScript to target a parent element or to extend page directly, but in doing so I found a few unexpected gotchas and complicated layout considerations.
So instead, I've modified the pattern to set
pointer-eventson the alert's container tonone, then resetting that value for child elements.Screenshots
With this change, it's now possible to select/click/etc. elements beneath the alert row:
While still being able to interact with content therein:
Testing
On the deploy preview, navigate to the Page Example with Alert story and confirm that you can interact with content within and beneath the
o-page__alertelement in the following browsers: