webpack build fix #294
Merged
webpack build fix #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1adn
commented
Aug 4, 2021
| @@ -20,8 +22,8 @@ module.exports = (env, argv) => { | |||
| filename: `[name]${lightFilenamePart}.js`, | |||
| chunkFilename: `[id]-[chunkhash]${lightFilenamePart}.js` | |||
| }, | |||
| optimization: optimization(argv.mode), | |||
| plugins: plugins(argv.mode) | |||
| optimization: optimization(mode), | |||
There was a problem hiding this comment.
the 'optimization' function never returned anything.
There was a problem hiding this comment.
It returns the configuration only if the mode is production.
| @@ -84,7 +84,7 @@ | |||
| "shx": "^0.3.3", | |||
| "snyk": "^1.653.0", | |||
| "source-map-loader": "1.1.3", | |||
| "terser-webpack-plugin": "^5.1.4", | |||
| "terser-webpack-plugin": "^4.2.3", | |||
There was a problem hiding this comment.
otherwise, get this error webpack-contrib/terser-webpack-plugin#335
e1adn
commented
Aug 4, 2021
| @@ -10,7 +10,9 @@ const OptimizeCssAssetsPlugin = require('optimize-css-assets-webpack-plugin'); | |||
| const TerserPlugin = require('terser-webpack-plugin'); | |||
|
|
|||
| module.exports = (env, argv) => { | |||
| lightFilenamePart = argv.mode === 'development' ? lightFilenamePart : lightFilenamePart + '.min'; | |||
| const isDevelopment = argv.mode === 'development'; | |||
| const mode = isDevelopment ? 'development' : 'production'; | |||
There was a problem hiding this comment.
'argv.mode' can be undefined
yaniv-li
approved these changes
Aug 4, 2021
| @@ -20,8 +22,8 @@ module.exports = (env, argv) => { | |||
| filename: `[name]${lightFilenamePart}.js`, | |||
| chunkFilename: `[id]-[chunkhash]${lightFilenamePart}.js` | |||
| }, | |||
| optimization: optimization(argv.mode), | |||
| plugins: plugins(argv.mode) | |||
| optimization: optimization(mode), | |||
There was a problem hiding this comment.
It returns the configuration only if the mode is production.
|
@yaniv-li it never did .. arg.mode was never equal to 'production' . we only pass mode='development' not mod='production' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.