-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: avoid hitting the API server when updating plugins status #4425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardoce
requested review from
fcanovai,
gbartolini,
mnencia,
phisco,
sxd and
armru
as code owners
May 2, 2024 14:12
github-actions
bot
added
backport-requested ◀️
This pull request should be backported to all supported releases
release-1.21
release-1.22
release-1.23
labels
May 2, 2024
❗ By default, the pull request is configured to backport to all release branches.
|
sxd
approved these changes
May 2, 2024
phisco
reviewed
May 2, 2024
When not needed, this patch avoids hitting the API server with a PATCH request. Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
mnencia
approved these changes
May 18, 2024
/test limit=local tl=4 |
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9142587121 |
phisco
approved these changes
May 18, 2024
/ok-to-merge some test failed but it's not related at all |
cnpg-bot
pushed a commit
that referenced
this pull request
May 19, 2024
When not needed, this patch avoids hitting the API server with a PATCH request. Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> (cherry picked from commit cc62f8f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-requested ◀️
This pull request should be backported to all supported releases
no-issue
ok to merge 👌
This PR can be merged
release-1.23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not needed, this patch avoids hitting the API server with a PATCH request.