-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run govulncheck only if go code changed #4473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-requested ◀️
This pull request should be backported to all supported releases
release-1.21
release-1.22
release-1.23
labels
May 8, 2024
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
❗ By default, the pull request is configured to backport to all release branches.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
jsilvela
force-pushed
the
dev/fix-govulncheck
branch
from
May 8, 2024 08:41
a597c10
to
db4b3e4
Compare
NiccoloFei
force-pushed
the
dev/fix-govulncheck
branch
from
May 15, 2024 12:32
db4b3e4
to
07ddb38
Compare
NiccoloFei
approved these changes
May 15, 2024
NiccoloFei
force-pushed
the
dev/fix-govulncheck
branch
from
May 17, 2024 09:56
d20ba20
to
b9af043
Compare
sxd
approved these changes
May 18, 2024
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
/ok-to-merge restrict go-vulncheck to go code in the CI |
cnpg-bot
pushed a commit
that referenced
this pull request
May 18, 2024
The CI pipeline is failing even for document-only PRs when govulncheck finds issues. govulncheck will now run only when some code it's modify and will exclude the documentation. Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com> (cherry picked from commit 3436f5b)
cnpg-bot
pushed a commit
that referenced
this pull request
May 18, 2024
The CI pipeline is failing even for document-only PRs when govulncheck finds issues. govulncheck will now run only when some code it's modify and will exclude the documentation. Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com> (cherry picked from commit 3436f5b)
cnpg-bot
pushed a commit
that referenced
this pull request
May 18, 2024
The CI pipeline is failing even for document-only PRs when govulncheck finds issues. govulncheck will now run only when some code it's modify and will exclude the documentation. Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com> (cherry picked from commit 3436f5b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-requested ◀️
This pull request should be backported to all supported releases
no-issue
ok to merge 👌
This PR can be merged
release-1.21
release-1.22
release-1.23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI pipeline is failing even for document-only PRs when
govulncheck finds issues.