Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run govulncheck only if go code changed #4473

Merged
merged 2 commits into from
May 18, 2024
Merged

ci: run govulncheck only if go code changed #4473

merged 2 commits into from
May 18, 2024

Conversation

jsilvela
Copy link
Collaborator

@jsilvela jsilvela commented May 8, 2024

The CI pipeline is failing even for document-only PRs when
govulncheck finds issues.

@jsilvela jsilvela requested a review from a team as a code owner May 8, 2024 08:40
@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.21 release-1.22 release-1.23 labels May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

github-actions bot commented May 8, 2024

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

Copy link
Contributor

github-actions bot commented May 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

jsilvela and others added 2 commits May 18, 2024 21:37
Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
@sxd
Copy link
Member

sxd commented May 18, 2024

/ok-to-merge restrict go-vulncheck to go code in the CI

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label May 18, 2024
@sxd sxd merged commit 3436f5b into main May 18, 2024
29 of 30 checks passed
@sxd sxd deleted the dev/fix-govulncheck branch May 18, 2024 19:54
cnpg-bot pushed a commit that referenced this pull request May 18, 2024
The CI pipeline is failing even for document-only PRs when
govulncheck finds issues.

govulncheck will now run only when some code it's modify and
will exclude the documentation.

Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
(cherry picked from commit 3436f5b)
cnpg-bot pushed a commit that referenced this pull request May 18, 2024
The CI pipeline is failing even for document-only PRs when
govulncheck finds issues.

govulncheck will now run only when some code it's modify and
will exclude the documentation.

Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
(cherry picked from commit 3436f5b)
cnpg-bot pushed a commit that referenced this pull request May 18, 2024
The CI pipeline is failing even for document-only PRs when
govulncheck finds issues.

govulncheck will now run only when some code it's modify and
will exclude the documentation.

Signed-off-by: Jaime Silvela <jaime.silvela@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
(cherry picked from commit 3436f5b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-requested ◀️ This pull request should be backported to all supported releases no-issue ok to merge 👌 This PR can be merged release-1.21 release-1.22 release-1.23
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants