Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to node 20 #71

Merged
merged 4 commits into from
Mar 7, 2024
Merged

upgrade to node 20 #71

merged 4 commits into from
Mar 7, 2024

Conversation

mcalhoun
Copy link
Member

@mcalhoun mcalhoun commented Mar 6, 2024

what

  • upgrade the action to node 20
  • update nock to 14@beta.5

why

  • node 16 is deprecated and nock <14 doesn't work with node 18 and above because it intercepts fetch calls, which are now natively part of node rather than an external library.

@mcalhoun mcalhoun requested review from a team as code owners March 6, 2024 19:01
@mcalhoun mcalhoun added the major Breaking changes (or first stable release) label Mar 6, 2024
@mcalhoun mcalhoun self-assigned this Mar 6, 2024
@mcalhoun mcalhoun requested a review from goruha March 6, 2024 19:08
osterman
osterman previously approved these changes Mar 6, 2024
@mcalhoun mcalhoun merged commit 7137afe into main Mar 7, 2024
1 check passed
@mcalhoun mcalhoun deleted the chore/upgrade/to-node-20 branch March 7, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Breaking changes (or first stable release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants