Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying GitHub OAuth token variable #175

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

justnom
Copy link
Contributor

@justnom justnom commented Dec 1, 2021

what

Clarifying what the github_oauth_token variable should contain.

why

The aws-codebuild module changed the default type for the github_token variable to PARAMTER_STORE from PLAINTEXT in this commit cloudposse/terraform-aws-codebuild@d078282.

references

@justnom justnom requested review from a team as code owners December 1, 2021 16:22
@nk9
Copy link

nk9 commented Jan 20, 2022

Wow, this is a pretty important change! Hopefully this can get merged quickly.

@Gowiem
Copy link
Member

Gowiem commented Jan 21, 2022

/test all

@Gowiem
Copy link
Member

Gowiem commented Apr 10, 2023

/test all

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge stale This PR has gone stale and removed wip Work in Progress: Not ready for final review or merge labels Mar 2, 2024
@mergify mergify bot added triage Needs triage and removed stale This PR has gone stale labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants