Fix EFS volume configuration getting discarded #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob-larvie-ctpg
approved these changes
Oct 16, 2023
nitrocode
reviewed
Oct 17, 2023
| @@ -167,7 +167,8 @@ module "ecs_alb_service_task" { | |||
| subnet_ids = var.ecs_private_subnet_ids | |||
| container_port = var.container_port | |||
| nlb_container_port = var.nlb_container_port | |||
| docker_volumes = var.volumes | |||
| docker_volumes = [for volume in var.volumes : volume if length(volume.docker_volume_configuration) > 0] | |||
There was a problem hiding this comment.
These conditions might be better in the ecs alb service task module instead of here
https://github.com/cloudposse/terraform-aws-ecs-alb-service-task
There was a problem hiding this comment.
@nitrocode Wouldn't that require the ecs alb service task module to be refactored to accept a generic volumes variable?
There was a problem hiding this comment.
Hmm i don't imagine there would be much of a refactoring. I'll defer to the @cloudposse/contributors if they have an opinion on it
There was a problem hiding this comment.
Happy to move this to ecs alb service task if needed. Just let me know what needs to be done to get this fix merged please
|
/terratest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
ecs-alb-service-taskmodule'sdocker_volumesorefs_volumesvariables based on whether they have non-emptydocker_volume_configurationorefs_volume_configurationlists.why
volumesvariable only getting passed to theecs-alb-service-taskmodule'sdocker_volumesvariable.references