Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Public Bucket Creation #194

Merged
merged 1 commit into from Jun 3, 2023
Merged

Fix Public Bucket Creation #194

merged 1 commit into from Jun 3, 2023

Conversation

rankin-tr
Copy link
Contributor

what

  • removes local.public_access_block_enabled
  • includes aws_s3_bucket_public_access_block for every bucket

why

  • aws_s3_bucket_public_access_block was not getting set, which prevented the use of public buckets.

references

@rankin-tr rankin-tr requested review from a team as code owners June 2, 2023 18:05
@Nuru Nuru added the bugfix Change that restores intended behavior label Jun 2, 2023
@Nuru
Copy link
Sponsor Contributor

Nuru commented Jun 2, 2023

/terratest

@Nuru Nuru merged commit 7030cbd into cloudposse:main Jun 3, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rankin-tr @Nuru