Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add elb account lookup #10

Merged
merged 4 commits into from Jun 2, 2021
Merged

add elb account lookup #10

merged 4 commits into from Jun 2, 2021

Conversation

mcalhoun
Copy link
Member

@mcalhoun mcalhoun commented Jun 2, 2021

what

  • Add a lookup for ELB accounts for Elastic Load Balancer accounts

why

  • When creating bucket policies to allow logging from ELB/ALB to write their access logs to S3, it is necessary to give permissions to the dedicated account the ELB/ALB is created in.

references

@mcalhoun mcalhoun requested review from a team as code owners June 2, 2021 14:07
@mcalhoun mcalhoun requested a review from a team as a code owner June 2, 2021 14:07
@mcalhoun mcalhoun requested review from Gowiem and adamcrews June 2, 2021 14:07
@mergify
Copy link

mergify bot commented Jun 2, 2021

This pull request is now in conflict. Could you fix it @mcalhoun? 🙏

@nitrocode
Copy link
Member

LGTM

@mcalhoun mcalhoun merged commit 22e2566 into master Jun 2, 2021
@mcalhoun mcalhoun deleted the feature/add-alb-access-logging-account-lookup branch June 2, 2021 14:36
@mcalhoun mcalhoun mentioned this pull request Jun 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@adamcrews adamcrews Awaiting requested review from adamcrews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcalhoun @nitrocode @cloudpossebot