Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add elb account lookup #11

Merged
merged 7 commits into from
Jun 2, 2021
Merged

add elb account lookup #11

merged 7 commits into from
Jun 2, 2021

Conversation

mcalhoun
Copy link
Member

@mcalhoun mcalhoun commented Jun 2, 2021

what

  • Update the outputs to make elb_logging_account its own output

why

@mcalhoun mcalhoun requested review from a team as code owners June 2, 2021 15:23
@mcalhoun mcalhoun requested review from woz5999 and SweetOps June 2, 2021 15:23
@mergify
Copy link

mergify bot commented Jun 2, 2021

This pull request is now in conflict. Could you fix it @mcalhoun? 🙏

korenyoni
korenyoni approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mcalhoun mcalhoun merged commit 7764737 into master Jun 2, 2021
@mcalhoun mcalhoun deleted the feature/add-alb-access-logging-account-lookup branch June 2, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korenyoni korenyoni korenyoni approved these changes

@woz5999 woz5999 Awaiting requested review from woz5999

@SweetOps SweetOps Awaiting requested review from SweetOps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcalhoun @korenyoni @cloudpossebot