Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tls] Provide an option to reload TLS certificates. #428

Merged
merged 6 commits into from Aug 1, 2023
Merged

[tls] Provide an option to reload TLS certificates. #428

merged 6 commits into from Aug 1, 2023

Conversation

manugarg
Copy link
Contributor

@manugarg manugarg commented Jul 31, 2023 •
edited

Couple of things for the records:

  • File cache is maintained by the file name. If multiple probes are using the same certificate, they will all access the same content, and they will all take the read lock, but read locks are cheap.
  • Certificate reload may get triggered sporadically if multiple probes (or targets) use the same certificate but specify different reload interval. This is unlikely and quite harmless I think, so not trying to solve that.

@manugarg manugarg mentioned this pull request Jul 31, 2023
Closed
@manugarg manugarg added this to the v0.12.9 milestone Aug 1, 2023
@manugarg manugarg merged commit c686c0c into master Aug 1, 2023
10 checks passed
@manugarg manugarg deleted the tls_reload branch August 1, 2023 23:52
@manugarg manugarg mentioned this pull request Aug 5, 2023
Merged
manugarg added a commit that referenced this pull request Aug 7, 2023
@manugarg
[tls] Cache the parsed certificate. (#441)
c41b7a6 
Previous PR (#428) added caching only for certificate files. This one caches parse certificates.
robpickerill pushed a commit to robpickerill/cloudprober that referenced this pull request Aug 7, 2023
@manugarg @robpickerill
[tls] Cache the parsed certificate. (cloudprober#441)
a6549ef 
Previous PR (cloudprober#428) added caching only for certificate files. This one caches parse certificates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbroglie cbroglie cbroglie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manugarg @cbroglie