Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[probes.grpc] Disable gRPC XDS support by default. #467

Merged
merged 1 commit into from Aug 21, 2023
Merged

[probes.grpc] Disable gRPC XDS support by default. #467

merged 1 commit into from Aug 21, 2023

Conversation

manugarg
Copy link
Contributor

  • gRPC XDS is not used widely, but if you really need it you can enable it by building cloudprober with the -tags grpc_xds flag.
  • This reduces cloudprober binary file size by 25% (41M -> 31M). I think it's criminal for a package to add that much to the binary size.

@manugarg
[probes.grpc] Disable gRPC XDS support by default.
cbb330b 
* gRPC XDS is not used widely, but if you really need it you can enable
it by building cloudprober with the `-tags grpc_xds` flag.
* This reduces cloudprober binary file size by 25% (41M -> 31M). I think
it's criminal for a package to add that much to the binary size.
@manugarg manugarg merged commit 8914201 into master Aug 21, 2023
10 checks passed
@manugarg manugarg added this to the v0.12.9 milestone Aug 21, 2023
@manugarg manugarg deleted the grpc_xds branch August 21, 2023 18:22
@manugarg manugarg mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.9
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@manugarg