Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slack alert implementation #475

Merged
merged 4 commits into from Aug 25, 2023

Conversation

robpickerill
Copy link
Contributor

This PR adds slack as a notifier and alerting mechanisms for probes.

Copy link
Contributor

@manugarg manugarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

probes/alerting/notifier/slack/slack.go Show resolved Hide resolved
probes/alerting/notifier/slack/slack.go Show resolved Hide resolved
@manugarg
Copy link
Contributor

@robpickerill, looks like my changes caused some conflict, I am not able to merge. Can you please resolve the conflicts and push again?

@robpickerill
Copy link
Contributor Author

please resolve the conflicts

no problems, should be good to merge now, thanks

@manugarg manugarg merged commit 5d564b7 into cloudprober:master Aug 25, 2023
8 checks passed
@manugarg manugarg added this to the v0.12.9 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants