Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Prevent import of surfacers code outside of surfacers package #477

Merged
merged 1 commit into from Aug 25, 2023

Conversation

manugarg
Copy link
Contributor

@manugarg manugarg commented Aug 25, 2023

It was always supposed to be this way. Go now (since 1.14) provides a way to enforce that.

Note: We still allow registering a custom surfacer so top-level surfacer package itself is public.

@manugarg manugarg merged commit 1d99a5f into master Aug 25, 2023
9 of 10 checks passed
@manugarg manugarg deleted the surfacers_internal branch August 25, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant