[validators.http] Add last modified header validation #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robpickerill
commented
Sep 2, 2023
manugarg
reviewed
Sep 5, 2023
manugarg
approved these changes
Sep 5, 2023
manugarg
force-pushed
the
last_modified_difference
branch
from
6a52cea
to
5a45cca
Compare
manugarg
changed the title
manugarg
reviewed
Sep 5, 2023
Co-authored-by: Manu Garg <manugarg@gmail.com>
|
My apologies Manu, I had missed the suggestion – now accepted and merged master, I think you should be good to go now, thanks! Edit: let me quickly patch up those tests. |
|
Patched, and you're now good to go! 👍 |
manugarg
approved these changes
Sep 7, 2023
Thanks! No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for validating if the last modified header is within the specified time duration.
Resolves #414